lkml.org 
[lkml]   [2013]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] mm/hugetlb: add more arch-defined huge_pte_xxx functions
On Tue 12-03-13 19:48:26, Gerald Schaefer wrote:
> Commit abf09bed3c "s390/mm: implement software dirty bits" introduced
> another difference in the pte layout vs. the pmd layout on s390,
> thoroughly breaking the s390 support for hugetlbfs. This requires
> replacing some more pte_xxx functions in mm/hugetlbfs.c with a
> huge_pte_xxx version.
>
> This patch introduces those huge_pte_xxx functions and their
> implementation on all architectures supporting hugetlbfs. This change
> will be a no-op for all architectures other than s390.
>
> Signed-off-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>
> ---
> arch/ia64/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++
> arch/mips/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++
> arch/powerpc/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++
> arch/s390/include/asm/hugetlb.h | 56 +++++++++++++++++++++++++++++++++++++-
> arch/s390/include/asm/pgtable.h | 20 --------------
> arch/s390/mm/hugetlbpage.c | 2 +-
> arch/sh/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++
> arch/sparc/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++
> arch/tile/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++
> arch/x86/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++
> mm/hugetlb.c | 23 ++++++++--------
> 11 files changed, 320 insertions(+), 33 deletions(-)

Ouch, this adds a lot of code that is almost same for all archs except
for some. Can we just make one common definition and define only those
that differ, please?
[...]
--
Michal Hocko
SUSE Labs


\
 
 \ /
  Last update: 2013-03-14 19:01    [W:0.068 / U:0.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site