lkml.org 
[lkml]   [2013]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] usb: gadget: remove MACH_OMAP_H4_OTG
From
Date
On Thu, 2013-03-14 at 16:13 +0200, Felipe Balbi wrote:
> On Mon, Mar 11, 2013 at 09:14:41PM +0100, Paul Bolle wrote:
> > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> > index 5a0c541..c65b5e2 100644
> > --- a/drivers/usb/gadget/Kconfig
> > +++ b/drivers/usb/gadget/Kconfig
> > @@ -194,7 +194,7 @@ config USB_FUSB300
> > config USB_OMAP
> > tristate "OMAP USB Device Controller"
> > depends on ARCH_OMAP1
> > - select ISP1301_OMAP if MACH_OMAP_H2 || MACH_OMAP_H3 || MACH_OMAP_H4_OTG
> > + select ISP1301_OMAP if MACH_OMAP_H2 || MACH_OMAP_H3
>
> could you, instead, just remove the entire line ? we have an overuse of
> select and this is one of those cases where it doesn't make sense.

Sure, but there's one problem: I need to come up with a descriptive
summary. "Remove "select" because Felipe told it makes no sense" might
not be good enough. Any hint why you think this entire line can be
dropped?


Paul Bolle



\
 
 \ /
  Last update: 2013-03-14 16:43    [W:0.064 / U:1.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site