Messages in this thread | | | Date | Thu, 14 Mar 2013 06:59:27 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH] hwmon: (pmbus) Fix krealloc() misuse in pmbus_add_attribute() |
| |
On Thu, Mar 14, 2013 at 01:30:20PM +0000, David Woodhouse wrote: > If krealloc() returns NULL, it *doesn't* free the original. So any code > of the form 'foo = krealloc(foo, …);' is almost certainly a bug. > > Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Good catch. Thanks a lot for the fix!
Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |