Messages in this thread | | | Subject | Re: [PATCH V4 2/3] mtd: add 4 Toshiba nand chips for the full-id case | From | Artem Bityutskiy <> | Date | Wed, 13 Mar 2013 12:55:57 +0200 |
| |
On Thu, 2013-03-07 at 18:49 +0800, Huang Shijie wrote: > + /* TOSHIBA */ > + {"TC58NVG2S0F 4G 3.3V 8-bit", > + { .id = {0x98, 0xdc, 0x90, 0x26, 0x76, 0x15, 0x01, 0x08}}, > + SZ_4K, SZ_512, SZ_256K, 0, 8, 224}, > + {"TC58NVG3S0F 8G 3.3V 8-bit", > + { .id = {0x98, 0xd3, 0x90, 0x26, 0x76, 0x15, 0x02, 0x08}}, > + SZ_4K, SZ_1K, SZ_256K, 0, 8, 232}, > + {"TC58NVG5D2 32G 3.3V 8-bit", > + { .id = {0x98, 0xd7, 0x94, 0x32, 0x76, 0x56, 0x09, 0x00}}, > + SZ_8K, SZ_4K, SZ_1M, 0, 8, 640}, > + {"TC58NVG6D2 64G 3.3V 8-bit", > + { .id = {0x98, 0xde, 0x94, 0x82, 0x76, 0x56, 0x04, 0x20}}, > + SZ_8K, SZ_8K, SZ_2M, 0, 8, 640},
We need a useful comment above this block explaining that it is important to have full ID records first.
-- Best Regards, Artem Bityutskiy
| |