Messages in this thread Patch in this message | | | Date | Tue, 12 Mar 2013 15:00:27 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH v3 2/7] usermodehelper: Export _exec() and _setup() functions |
| |
On Tue, 12 Mar 2013 18:52:54 -0300 Lucas De Marchi <lucas.demarchi@profusion.mobi> wrote:
> On Tue, Mar 12, 2013 at 5:31 PM, Andrew Morton > <akpm@linux-foundation.org> wrote: > > On Mon, 11 Mar 2013 21:48:06 -0300 Lucas De Marchi <lucas.demarchi@profusion.mobi> wrote: > > > >> call_usermodehelper_setup() + call_usermodehelper_exec() need to be > >> called instead of call_usermodehelper_fns() when the cleanup function > >> needs to be called even when an ENOMEM error occurs. In this case using > >> call_usermodehelper_fns() the user can't distinguish if the cleanup > >> function was called or not. > > > > call_usermodehelper_exec() was exported to modules but > > call_usermodehelper_setup() was not? > > > > That was a mistake. We need both functions exported. Should I send and > updated patch or a fixup?
From: Andrew Morton <akpm@linux-foundation.org> Subject: usermodehelper-export-_exec-and-_setup-functions-fix
export call_usermodehelper_setup() to modules
Cc: "Rafael J. Wysocki" <rjw@sisk.pl> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: David Howells <dhowells@redhat.com> Cc: James Morris <james.l.morris@oracle.com> Cc: Lucas De Marchi <lucas.demarchi@profusion.mobi> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Tejun Heo <tj@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> ---
kernel/kmod.c | 1 + 1 file changed, 1 insertion(+)
diff -puN kernel/kmod.c~usermodehelper-export-_exec-and-_setup-functions-fix kernel/kmod.c --- a/kernel/kmod.c~usermodehelper-export-_exec-and-_setup-functions-fix +++ a/kernel/kmod.c @@ -541,6 +541,7 @@ struct subprocess_info *call_usermodehel out: return sub_info; } +EXPORT_SYMBOL(call_usermodehelper_setup); /** * call_usermodehelper_exec - start a usermode application _
| |