lkml.org 
[lkml]   [2013]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 5/7] CIFS: Translate SHARING_VIOLATION to -ETXTBSY error code for SMB2
    On Thu, 28 Feb 2013 19:25:31 +0400
    Pavel Shilovsky <piastry@etersoft.ru> wrote:

    > to make it match CIFS and VFS variants.
    >
    > Signed-off-by: Pavel Shilovsky <piastry@etersoft.ru>
    > ---
    > fs/cifs/smb2maperror.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/fs/cifs/smb2maperror.c b/fs/cifs/smb2maperror.c
    > index 494c912..11e589e 100644
    > --- a/fs/cifs/smb2maperror.c
    > +++ b/fs/cifs/smb2maperror.c
    > @@ -356,7 +356,7 @@ static const struct status_to_posix_error smb2_error_map_table[] = {
    > {STATUS_PORT_CONNECTION_REFUSED, -ECONNREFUSED,
    > "STATUS_PORT_CONNECTION_REFUSED"},
    > {STATUS_INVALID_PORT_HANDLE, -EIO, "STATUS_INVALID_PORT_HANDLE"},
    > - {STATUS_SHARING_VIOLATION, -EBUSY, "STATUS_SHARING_VIOLATION"},
    > + {STATUS_SHARING_VIOLATION, -ETXTBSY, "STATUS_SHARING_VIOLATION"},
    > {STATUS_QUOTA_EXCEEDED, -EDQUOT, "STATUS_QUOTA_EXCEEDED"},
    > {STATUS_INVALID_PAGE_PROTECTION, -EIO,
    > "STATUS_INVALID_PAGE_PROTECTION"},

    Actually, I think Sachin is converting the CIFS
    STATUS_SHARING_VIOLATION to translate to EBUSY, since that seems to
    better reflect the situation. I'd suggest dropping this patch, unless
    you have a specific need for this error return here.

    --
    Jeff Layton <jlayton@redhat.com>


    \
     
     \ /
      Last update: 2013-03-11 20:22    [W:2.438 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site