lkml.org 
[lkml]   [2013]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [patch] [SCSI] bfa: Use GFP_ATOMIC under spin_lock
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Friday, March 08, 2013 4:01 AM
> To: Anil Gurumurthy
> Cc: Vijay Mohan Guvva; James E.J. Bottomley; linux-scsi@vger.kernel.org;
> linux-kernel@vger.kernel.org; kernel-janitors@vger.kernel.org
> Subject: [patch] [SCSI] bfa: Use GFP_ATOMIC under spin_lock
>
> This is always called with spinlocks held so it should use GFP_ATOMIC. The
> call tree is:
>
> -> bfad_drv_start()
> Takes spin_lock_irqsave(&bfad->bfad_lock, flags);
> -> bfa_fcs_pbc_vport_init()
> -> bfa_fcb_pbc_vport_create()
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/scsi/bfa/bfad.c b/drivers/scsi/bfa/bfad.c index
> a5f7690..d144a06 100644
> --- a/drivers/scsi/bfa/bfad.c
> +++ b/drivers/scsi/bfa/bfad.c
> @@ -491,7 +491,7 @@ bfa_fcb_pbc_vport_create(struct bfad_s *bfad,
> struct bfi_pbc_vport_s pbc_vport)
> struct bfad_vport_s *vport;
> int rc;
>
> - vport = kzalloc(sizeof(struct bfad_vport_s), GFP_KERNEL);
> + vport = kzalloc(sizeof(struct bfad_vport_s), GFP_ATOMIC);
> if (!vport) {
> bfa_trc(bfad, 0);
> return;

Changes looks good. Thanks for the patch.
Acked-by: Vijay Mohan Guvva <vmohan@Brocade.com>


\
 
 \ /
  Last update: 2013-03-11 20:05    [W:0.050 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site