Messages in this thread | | | Date | Mon, 11 Mar 2013 19:02:30 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCHv2] perf: Fix vmalloc ring buffer free function |
| |
On Mon, Mar 11, 2013 at 06:44:45PM +0100, Peter Zijlstra wrote: > On Mon, 2013-03-11 at 17:43 +0100, Jiri Olsa wrote: > > > I did not know there were other plans for that, seemed useless > > I like to keep form, confuses me less :-)
ook
> > Anyway, why are we getting to that part of perf_output_begin() if we > don't have any data pages to begin with? Shouldn't we bail before there > someplace? Like at the !rb->nr_pages check? >
perf_output_begin actually does the !rb->nr_pages check looks like we could check it earlier in some casese, I'll update my todo list ;-)
jirka
| |