Messages in this thread | | | Subject | Re: [PATCHv2] perf: Fix vmalloc ring buffer free function | From | Peter Zijlstra <> | Date | Mon, 11 Mar 2013 17:26:33 +0100 |
| |
On Mon, 2013-03-11 at 12:21 +0100, Jiri Olsa wrote: > > pg_nr = offset >> page_shift; > > pg_offset = offset & (1 << page_shift) - 1; > > > > You just wrecked that. > > > > > handle->page &= rb->nr_pages - 1; > > here's ^^^ where the handle->page becomes 0 due to (rb->nr_pages == 0)
then that'll be &= -1, which is a nop, no?
Also, you wrecked it for anything that uses some intermediate page order (we currently don't).
| |