Messages in this thread | | | Subject | Re: [PATCH] drivers: thermal: cpu_cooling: fix checkpatch warning | From | Zhang Rui <> | Date | Mon, 11 Mar 2013 22:24:28 +0800 |
| |
On Tue, 2013-02-26 at 14:42 +0100, Laurent Navet wrote: > - WARNING: Avoid CamelCase: <maskPtr> > > Signed-off-by: Laurent Navet <laurent.navet@gmail.com> > --- > drivers/thermal/cpu_cooling.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c > index 836828e..47b7d32 100644 > --- a/drivers/thermal/cpu_cooling.c > +++ b/drivers/thermal/cpu_cooling.c > @@ -175,8 +175,8 @@ static int cpufreq_apply_cooling(struct cpufreq_cooling_device *cpufreq_device, > unsigned long cooling_state) > { > unsigned int cpuid, clip_freq; > - struct cpumask *maskPtr = &cpufreq_device->allowed_cpus; > - unsigned int cpu = cpumask_any(maskPtr); > + struct cpumask *mask = &cpufreq_device->allowed_cpus; > + unsigned int cpu = cpumask_any(mask); > > > /* Check if the old cooling action is same as new cooling action */ > @@ -191,7 +191,7 @@ static int cpufreq_apply_cooling(struct cpufreq_cooling_device *cpufreq_device, > cpufreq_device->cpufreq_val = clip_freq; > notify_device = cpufreq_device; > > - for_each_cpu(cpuid, maskPtr) { > + for_each_cpu(cpuid, mask) { > if (is_cpufreq_valid(cpuid)) > cpufreq_update_policy(cpuid); > } why not fix the code in cpufreq_get_max_state() as well, in one patch?
thanks, rui
| |