lkml.org 
[lkml]   [2013]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] s390: replace kmalloc + memset with kzalloc
On Sun, Mar 10, 2013 at 04:14:00PM +0200, Pekka Enberg wrote:
> On Sun, Mar 10, 2013 at 3:13 PM, Stelian Nirlu <steliannirlu@gmail.com> wrote:
> > Signed-off-by: Stelian Nirlu <steliannirlu@gmail.com>
> > ---
> > arch/s390/net/bpf_jit_comp.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/arch/s390/net/bpf_jit_comp.c b/arch/s390/net/bpf_jit_comp.c
> > index 0972e91..e645528 100644
> > --- a/arch/s390/net/bpf_jit_comp.c
> > +++ b/arch/s390/net/bpf_jit_comp.c
> > @@ -747,10 +747,9 @@ void bpf_jit_compile(struct sk_filter *fp)
> >
> > if (!bpf_jit_enable)
> > return;
> > - addrs = kmalloc(fp->len * sizeof(*addrs), GFP_KERNEL);
> > + addrs = kzalloc(fp->len * sizeof(*addrs), GFP_KERNEL);
>
> kcalloc() might be more appropriate here to protect against integer
> overflow if "fp->len" is too large.

Stelian, care to send an updated patch which uses kcalloc()
instead of kzalloc()?



\
 
 \ /
  Last update: 2013-03-11 13:21    [W:0.045 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site