lkml.org 
[lkml]   [2013]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] backlight: adp8870: add missing braces
Date
This patch adds missing braces to include error message.
The error message is related to the return value for
sysfs_create_group(). However, sysfs_create_group() is called
when pdata->en_ambl_sens is not zero. Thus, the checking return
value should be included in the if statement.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/adp8870_bl.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/video/backlight/adp8870_bl.c b/drivers/video/backlight/adp8870_bl.c
index 712c25a..7930ab3 100644
--- a/drivers/video/backlight/adp8870_bl.c
+++ b/drivers/video/backlight/adp8870_bl.c
@@ -895,13 +895,13 @@ static int adp8870_probe(struct i2c_client *client,

data->bl = bl;

- if (pdata->en_ambl_sens)
+ if (pdata->en_ambl_sens) {
ret = sysfs_create_group(&bl->dev.kobj,
&adp8870_bl_attr_group);
-
- if (ret) {
- dev_err(&client->dev, "failed to register sysfs\n");
- goto out1;
+ if (ret) {
+ dev_err(&client->dev, "failed to register sysfs\n");
+ goto out1;
+ }
}

ret = adp8870_bl_setup(bl);
--
1.7.2.5



\
 
 \ /
  Last update: 2013-03-11 11:21    [W:0.198 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site