Messages in this thread | | | Date | Mon, 11 Mar 2013 09:33:34 +0800 | From | "tiejun.chen" <> | Subject | Re: [PATCH]->[PATCH v2] kgdb: Removed kmalloc returned value cast |
| |
On 03/11/2013 06:39 AM, Alex Grad wrote: > While at it, check kmalloc return value. > > Signed-off-by: Alex Grad <alex.grad@gmail.com> > --- > arch/powerpc/kernel/kgdb.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c > index 5ca82cd..9e81dd8 100644 > --- a/arch/powerpc/kernel/kgdb.c > +++ b/arch/powerpc/kernel/kgdb.c > @@ -159,7 +159,10 @@ static int kgdb_singlestep(struct pt_regs *regs) > if (user_mode(regs)) > return 0; > > - backup_current_thread_info = (struct thread_info *)kmalloc(sizeof(struct thread_info), GFP_KERNEL); > + backup_current_thread_info = kmalloc(sizeof(struct thread_info), GFP_KERNEL); > + if (!backup_current_thread_info) > + return -ENOMEM;
I already send a kgdb patchset in "[v3][PATCH 6/6] powerpc/kgdb: remove copying the thread_info" to remove these stuff since its unnecessary to copy current thread_info now.
Tiejun
| |