Messages in this thread | | | Date | Sun, 10 Mar 2013 16:23:01 -0700 | Subject | Re: [PATCH] fs: pstore: Replaced calls to kmalloc and memcpy with kmemdup | From | Kees Cook <> |
| |
On Sat, Mar 9, 2013 at 3:57 AM, Alexandru Gheorghiu <gheorghiuandru@gmail.com> wrote: > Replaced calls to kmalloc and memcpy with a single call to kmemdup. > This patch was found using coccicheck. > > Signed-off-by: Alexandru Gheorghiu <gheorghiuandru@gmail.com> > --- > fs/pstore/ram.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c > index 288f068..38babb3 100644 > --- a/fs/pstore/ram.c > +++ b/fs/pstore/ram.c > @@ -156,10 +156,9 @@ static ssize_t ramoops_pstore_read(u64 *id, enum pstore_type_id *type, > time->tv_nsec = 0; > > size = persistent_ram_old_size(prz); > - *buf = kmalloc(size, GFP_KERNEL); > + *buf = kmemdup(persistent_ram_old(prz), size, GFP_KERNEL); > if (*buf == NULL) > return -ENOMEM; > - memcpy(*buf, persistent_ram_old(prz), size); > > return size; > }
Looks fine to me. Thanks!
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
-- Kees Cook Chrome OS Security
| |