Messages in this thread | | | Date | Sun, 10 Mar 2013 18:02:18 -0400 (EDT) | Subject | Re: [PATCH] eicon: Fixed checkpatch warning | From | David Miller <> |
| |
From: David Miller <davem@davemloft.net> Date: Sun, 10 Mar 2013 16:56:13 -0400 (EDT)
> From: Andreea Hodea <andreea.cristina.hodea@gmail.com> > Date: Sun, 10 Mar 2013 14:34:36 +0200 > >> drivers/isdn/hardware/eicon/diva_didd.c:32:6: warning: symbol >> 'DRIVERRELEASE_DIDD' was not declared. Should it be static? >> >> Signed-off-by: Andreea Hodea <hodea_andreea@yahoo.com> > > Applied, thanks.
I had to revert, did you even try to compile the driver after this change?
The symbol is refenced by DbgRegister() calls in diddfunc.c, and a very simple grep would have shown that to you.
Please do not just blindly try to fix checkpatch warnings.
| |