lkml.org 
[lkml]   [2013]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] eicon: Fixed checkpatch warning
From
From: David Miller <davem@davemloft.net>
Date: Sun, 10 Mar 2013 16:56:13 -0400 (EDT)

> From: Andreea Hodea <andreea.cristina.hodea@gmail.com>
> Date: Sun, 10 Mar 2013 14:34:36 +0200
>
>> drivers/isdn/hardware/eicon/diva_didd.c:32:6: warning: symbol
>> 'DRIVERRELEASE_DIDD' was not declared. Should it be static?
>>
>> Signed-off-by: Andreea Hodea <hodea_andreea@yahoo.com>
>
> Applied, thanks.

I had to revert, did you even try to compile the driver after
this change?

The symbol is refenced by DbgRegister() calls in diddfunc.c, and
a very simple grep would have shown that to you.

Please do not just blindly try to fix checkpatch warnings.


\
 
 \ /
  Last update: 2013-03-10 23:41    [W:0.037 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site