Messages in this thread | | | Date | Sun, 10 Mar 2013 16:10:56 +0200 | Subject | Re: [PATCH] kgdb: Removed kmalloc returned value cast | From | Pekka Enberg <> |
| |
On Sun, Mar 10, 2013 at 3:06 PM, Alex Grad <alex.grad@gmail.com> wrote: > Signed-off-by: Alex Grad <alex.grad@gmail.com> > --- > arch/powerpc/kernel/kgdb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c > index 5ca82cd..c1eef24 100644 > --- a/arch/powerpc/kernel/kgdb.c > +++ b/arch/powerpc/kernel/kgdb.c > @@ -159,7 +159,7 @@ static int kgdb_singlestep(struct pt_regs *regs) > if (user_mode(regs)) > return 0; > > - backup_current_thread_info = (struct thread_info *)kmalloc(sizeof(struct thread_info), GFP_KERNEL); > + backup_current_thread_info = kmalloc(sizeof(struct thread_info), GFP_KERNEL);
Looks good to me.
There's two additional problems in the kgdb_singlestep() function: it doesn't check if the kmalloc() call fails nor does it kfree() the allocated memory.
Pekka
| |