lkml.org 
[lkml]   [2013]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: kernel BUG at fs/sysfs/group.c:65!
(cc'ing Jens)

Hello,

On Sun, Mar 10, 2013 at 04:53:11PM +0800, Ming Lei wrote:
> On Sun, Mar 10, 2013 at 12:36 AM, Tommi Rantala <tt.rantala@gmail.com> wrote:
> > [ 40.089036] [<ffffffff81222e29>] sysfs_get_dirent+0x39/0x80
> > [ 40.089036] [<ffffffff81224ad9>] sysfs_remove_group+0x29/0x100
> > [ 40.089036] [<ffffffff8113f2c4>] blk_trace_remove_sysfs+0x14/0x20
> > [ 40.089036] [<ffffffff813453ae>] blk_unregister_queue+0x5e/0x90
> > [ 40.089036] [<ffffffff8134d417>] del_gendisk+0x107/0x250
> > [ 40.089036] [<ffffffff814f66b8>] loop_remove+0x18/0x40
>
> Then the crash is triggered in device release path, which should have
> been avoided in device add path.
>
> If we want to fix the problem completely, add_disk() must handle failure
> path correctly and return error code on failures, which may involve big
> work, since add_disk() are called by 50+ drivers.

Yeah, add_disk() has been broken like that since forever. We really
need to fix it properly. Any volunteers?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2013-03-10 13:41    [W:1.009 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site