Messages in this thread |  | | From | Grant Likely <> | Subject | Re: [PATCH v3] gpio: twl4030: Cache the direction and output states in private data | Date | Sat, 09 Feb 2013 14:15:44 +0000 |
| |
On Thu, 10 Jan 2013 14:09:35 +0100, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote: > Hi Linus, > > On 01/10/2013 11:41 AM, Linus Walleij wrote: > > On Thu, Dec 20, 2012 at 10:44 AM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote: > > > >> Use more coherent locking in the driver. Use bitfield to store the GPIO > >> direction and if the pin is configured as output store the status also in a > >> bitfiled. > >> In this way we can just look at these bitfields when we need information > >> about the pin status and only reach out to the chip when it is needed. > >> > >> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > >> Acked-by: Linus Walleij <linus.walleij@linaro.org> > >> --- > >> Hi Grant, > >> > >> Changes sicne v2: > >> - Fixed the mutex_unlock found by Michael. > >> - Removed the debug prints addedd by v2 patch (remains from debugging) > >> - Removed one blank line between includes and the first comment section. > > > > Sorry Peter this must have been missed somehow. > > > > This does not apply to the current v3.8-rc3, could you respin > > this on top of Torvalds' tree? > > Grant applied the patch which this one depends on: > [1] https://patchwork.kernel.org/patch/1844511/
I had applied it, never pushed the tree out because I wasn't able to test my kernel tree for a couple of weeks due to travel. I saw the patch in Linus' tree and pulled it out of mine before I pushed it out.
g.
|  |