[lkml]   [2013]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3] gpio: vt8500: memory cleanup missing
On Fri, 18 Jan 2013 17:58:22 +1300, Tony Prisk <> wrote:
> This driver is missing a .remove callback, and the fail path on
> probe is incomplete.
> If an error occurs in vt8500_add_chips, gpio_base is not unmapped.
> The driver is also ignoring the return value from this function so
> if a chip fails to register it completes as successful.
> Replaced pr_err with dev_err in vt8500_add_chips since the device is
> available.
> There is also no .remove callback defined so the function is added.
> Signed-off-by: Tony Prisk <>

Applied, thanks.


 \ /
  Last update: 2013-02-09 14:41    [W:0.022 / U:1.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site