Messages in this thread |  | | Date | Sat, 9 Feb 2013 11:47:52 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 1/2] add helper for highmem checks |
| |
On Sat, Feb 09, 2013 at 10:41:21AM +0100, Borislav Petkov wrote: > > +static inline bool phys_addr_is_highmem(phys_addr_t addr) > > +{ > > + return addr > last_lowmem_paddr(); > > I think you mean last_lowmem_phys_addr() here: > > include/linux/mm.h: In function ‘phys_addr_is_highmem’: > include/linux/mm.h:1764:2: error: implicit declaration of function ‘last_lowmem_paddr’ [-Werror=implicit-function-declaration] > cc1: some warnings being treated as errors > make[1]: *** [arch/x86/kernel/asm-offsets.s] Error 1 > > Changed.
With this change, they definitely fix something because I even get X on the box started. Previously, it would spit out the warning and wouldn't start X with the login window. And my suspicion is that wdm (WINGs display manager) I'm using, does /dev/mem accesses when it starts and it obviously failed. Now not so much :-)
Tested-by: Borislav Petkov <bp@suse.de>
Thanks.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |