lkml.org 
[lkml]   [2013]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 5/9] gpiolib: use gpio_chips list in gpiochip_find_base
Date
On Wed, 6 Feb 2013 13:48:19 +0900, Alex Courbot <acourbot@nvidia.com> wrote:
> On 02/06/2013 02:21 AM, Linus Walleij wrote:
> > This looks like it is preserving this userspace-sensitive semantic
> > so that dynamically added chips will still get the same assigned
> > numbers.
>
> It does (it should, at least), the assigned ranges should be strictly
> identical to the previous version. While testing I also made sure all
> chips had the same GPIO range.
>
> > But I want some guarantees, so state clearly in the commit
> > that any dynamically assigned chip will get the same base
> > address after this change as it got before it, and please take
> > this opportunity to add a comment stating that this search
> > method is vital for userspace ABIs, and must be preserved.
>
> Done. I will take the blame if something goes wrong. :)

Applied, thanks

g.



\
 
 \ /
  Last update: 2013-02-09 11:41    [W:0.068 / U:0.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site