Messages in this thread | | | Date | Sat, 9 Feb 2013 14:36:53 -0800 | From | Anton Vorontsov <> | Subject | Re: [PATCH] gpio: Add device driver for GRGPIO cores |
| |
On Mon, Feb 04, 2013 at 11:27:33AM +0100, Andreas Larsson wrote: [...] > >>2) The grgpio_to_irq function is very hardware specific, and there is of > >>course no gpio_to_irq support in gpio-generic. > > > >Well, the idea about gpio-generic is to use the pieces you need > >IIRC. You may override. > > Ah, I see, bgpio_init is exported, so I might be able use that from > my driver to get rid of some functions. There is support for BE I > saw now. It seems broken to me (flips bits, not bytes), but that can > be fixed.
No, it is not broken. :-) There is a BE-notation of GPIO numbering. BE/LE issue is also valid for bits. Please don't "fix" this. :)
If you need to introduce byte endianness support in addition, that's fine.
Thanks,
Anton
| |