Messages in this thread | | | From | "R, Durgadoss" <> | Subject | RE: [PATCH 1/8] Thermal: Create sensor level APIs | Date | Fri, 8 Feb 2013 08:26:53 +0000 |
| |
Hi Rui,
> -----Original Message----- > From: Zhang, Rui > Sent: Friday, February 08, 2013 1:24 PM > To: R, Durgadoss > Cc: linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org; > eduardo.valentin@ti.com; hongbo.zhang@linaro.org; wni@nvidia.com > Subject: Re: [PATCH 1/8] Thermal: Create sensor level APIs > > On Tue, 2013-02-05 at 16:16 +0530, Durgadoss R wrote: > > This patch creates sensor level APIs, in the > > generic thermal framework.
[snip.]
> > + > > static ssize_t > > type_show(struct device *dev, struct device_attribute *attr, char *buf) > > { > > @@ -707,6 +807,10 @@ static DEVICE_ATTR(mode, 0644, mode_show, > mode_store); > > static DEVICE_ATTR(passive, S_IRUGO | S_IWUSR, passive_show, > passive_store); > > static DEVICE_ATTR(policy, S_IRUGO | S_IWUSR, policy_show, > policy_store); > > > > +/* Thermal sensor attributes */ > > +static DEVICE_ATTR(sensor_name, 0444, sensor_name_show, NULL); > > +static DEVICE_ATTR(temp_input, 0444, sensor_temp_show, NULL); > > + > > /* sys I/F for cooling device */ > > #define to_cooling_device(_dev) \ > > container_of(_dev, struct thermal_cooling_device, device) > > @@ -1493,6 +1597,182 @@ static void remove_trip_attrs(struct > thermal_zone_device *tz) > > } > > > > /** > > + * enable_sensor_thresholds - create sysfs nodes for thresholdX > > this is a little confusing. > I'd prefer > thermal_sensor_sysfs_add() and create sensor_name and temp_input > attribute in this function as well, and thermal_sensor_sysfs_remove() > to remove the sysfs I/F. > And further more, we can do this for thermal zones and cooling devices.
I agree, and we will change this. Since this involves change for all standard APIs, I think it is better to submit a separate patch to do this. What do you think ?
> > others look okay to me.
Thank you :-)
> > thanks, > rui
| |