Messages in this thread | | | From | "Hefty, Sean" <> | Subject | RE: [PATCH 2/6] idr: remove MAX_IDR_MASK and move left MAX_IDR_* into idr.c | Date | Fri, 8 Feb 2013 22:09:13 +0000 |
| |
> * drivers/infiniband/core/cm.c:cm_alloc_id() > drivers/infiniband/hw/mlx4/cm.c:id_map_alloc() > > Used to wrap cyclic @start. Can be replaced with max(next, 0). > Note that this type of cyclic allocation using idr is buggy. These > are prone to spurious -ENOSPC failure after the first wraparound.
The replacement code looks fine, but can you explain why the use is buggy?
| |