Messages in this thread |  | | Date | Fri, 8 Feb 2013 11:24:39 +0530 | Subject | Re: [BUG] cpufreq: sleeping function called from invalid context at kernel/workqueue.c:2811 | From | Viresh Kumar <> |
| |
On 7 February 2013 06:11, Rafael J. Wysocki <rjw@sisk.pl> wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Subject: cpufreq: Move sysfs_remove_link() from under a spinlock > > Commit 73bf0fc "cpufreq: Don't remove sysfs link for policy->cpu" > attempted to fix a bug in __cpufreq_remove_dev() by avoiding to > remove the link to the "cpufreq" directory for policy->cpu, but it > rearranged the code in such a way that sysfs_remove_link() ended up > under a spinlock, which caused complaints about sleeping in atomic > context to be emitted into the kernel log during system suspend. > > To fix this, revert commit 73bf0fc partially and move the > sysfs_remove_link() in question to a separate block executed for > cpus > 1 outside of the spinlock. > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
BTW, i have dropped this patch completely as i got another lock fixing patch :)
|  |