lkml.org 
[lkml]   [2013]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/5] cpufreq: Only call cpufreq_out_of_sync() with drivers that implement cpufreq_driver.target()
    From
    On Wed, Feb 6, 2013 at 10:32 PM,  <dirk.brandewie@gmail.com> wrote:
    > From: Dirk Brandewie <dirk.brandewie@gmail.com>
    >
    > Scaling drivers that implement cpufreq_driver.setpolicy() have
    > internal governors that do not signal changes via
    > cpufreq_notify_transition() so the frequncy in the policy will almost
    > certainly be different than the current frequncy. Only call
    > cpufreq_out_of_sync() when the underlying driver implements
    > cpufreq_driver.target()
    >
    > Signed-off-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
    > ---
    > drivers/cpufreq/cpufreq.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
    > index bb45f93..0ba0344 100644
    > --- a/drivers/cpufreq/cpufreq.c
    > +++ b/drivers/cpufreq/cpufreq.c
    > @@ -1798,7 +1798,7 @@ int cpufreq_update_policy(unsigned int cpu)
    > pr_debug("Driver did not initialize current freq");
    > data->cur = policy.cur;
    > } else {
    > - if (data->cur != policy.cur)
    > + if (data->cur != policy.cur && driver->target)
    > cpufreq_out_of_sync(cpu, data->cur,
    > policy.cur);

    Looks much better now :)


    \
     
     \ /
      Last update: 2013-02-07 12:21    [W:4.230 / U:1.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site