[lkml]   [2013]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 0/2] ACPI / scan: Remove useless #ifndef and simplify container driver
Hi Rafael,

2013/02/08 9:24, Rafael J. Wysocki wrote:
> On Monday, February 04, 2013 12:47:31 AM Rafael J. Wysocki wrote:
>> From: Rafael J. Wysocki <>
>> The only useful thing that the ACPI container driver does is to
>> install system notify handlers for all container and module device
>> objects it finds in the namespace. The driver structure,
>> acpi_container_driver, and the data structures created by its
>> .add() callback are in fact not used by the driver, so remove
>> them entirely.
>> It also makes a little sense to build that driver as a module,
>> so make it non-modular and add its initialization to the
>> namespace scanning code.
>> In addition to that, make the namespace walk callback used for
>> installing the notify handlers more straightforward.
> As pointed out by Toshi Kani, the above changes would make acpi_eject_store()
> fail for containers and it is the only way to eject them currently, so patch
> [2/2] is an improved version of this (with Toshi's changes folded in).
> Patch [1/2] is just a cleanup removing a useless #ifndef from acpi_eject_store().

I confimed the patch series works well.

Acked-by: Yasuaki Ishimatsu <>
Tested-by: Yasuaki Ishimatsu <>

Yasuaki Ishimatsu

> Thanks,
> Rafael

 \ /
  Last update: 2013-02-08 05:01    [W:0.152 / U:1.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site