Messages in this thread Patch in this message | | | From | Namhyung Kim <> | Subject | [PATCH 5/7] perf annotate: Fix warning message on a missing vmlinux | Date | Thu, 7 Feb 2013 18:02:12 +0900 |
| |
From: Namhyung Kim <namhyung.kim@lge.com>
When perf annotate runs with no vmlinux file it cannot annotate kernel symbols because the kallsyms only provides symbol addresses. So it recommends to run perf buildid-cache to install proper vmlinux image.
But running perf buildid-cache -av vmlinux as the message gives me a following error:
$ perf buildid-cache -av /home/namhyung/build/kernel/vmlinux Couldn't add v: No such file or directory
Since the -a option receives a parameter, 'v' should not be after the option.
In addition -a option is not work for this case since the build-id cache already has a kallsyms with same build-id so it'll fail with EEXIST. Use recently added -u (--update) option for it.
Signed-off-by: Namhyung Kim <namhyung@kernel.org> --- tools/perf/util/annotate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index 07aaeea60000..d33fe937e6f1 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf/util/annotate.c @@ -809,7 +809,7 @@ fallback: pr_err("Can't annotate %s:\n\n" "No vmlinux file%s\nwas found in the path.\n\n" "Please use:\n\n" - " perf buildid-cache -av vmlinux\n\n" + " perf buildid-cache -vu vmlinux\n\n" "or:\n\n" " --vmlinux vmlinux\n", sym->name, build_id_msg ?: ""); -- 1.7.11.7
| |