lkml.org 
[lkml]   [2013]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] xen-pciback: notify hypervisor about devices intended to be assigned to guests
>>> On 06.02.13 at 18:12, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
>> + if (pci_find_capability(dev, PCI_CAP_ID_MSIX)) {
>> + struct physdev_pci_device ppdev = {
>> + .seg = pci_domain_nr(dev->bus),
>> + .bus = dev->bus->number,
>> + .devfn = dev->devfn
>> + };
>> + int err = HYPERVISOR_physdev_op(PHYSDEVOP_release_msix,
>> + &ppdev);
>> +
>> + if (err)
>> + dev_warn(&dev->dev, "MSI-X release failed (%d)\n",
>> + err);
>> + }
>
> Perhaps it should be more off:
>
> if (err) {
> if (err == -ENOSYS)
> dev_info(&dev->dev,"MSI-X release
> hypercall not supported.");
> else
> dev_warn(&dev->dev, "MSI-X release failed (%d)\n",
> err);
>

Why would you want to special case this? The more that _really_
old hypervisors returned -EINVAL instead of -ENOSYS here?

Jan



\
 
 \ /
  Last update: 2013-02-07 10:42    [W:0.034 / U:1.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site