Messages in this thread | | | From | "Michael Kerrisk (man-pages)" <> | Date | Fri, 8 Feb 2013 01:35:14 +0100 | Subject | Re: [PATCH 2/3] signalfd: add ability to choose a private or shared queue |
| |
On Thu, Feb 7, 2013 at 7:17 PM, Oleg Nesterov <oleg@redhat.com> wrote: > AOn 01/22, Andrey Vagin wrote: >> >> This patch is added two flags SFD_SHARED_QUEUE and SFD_PER_THREAD_QUEUE >> SFD_SHARED_QUEUE > > I can't believe I am going to blame the naming ;) but these 2 do not look > "symmetrical".... > > SFD_PRIVATE_QUEUE looks a little bit better to me. At least it is simpler > to type. But I am fine either way.
At the risk of bikeshedding.... The point is that there are two queues, the process-wide queue or the per-thread queue. "Private" does not come into. And "Shared" is a little confusing. Adding those two terms into the mix is just confusing: it doesn't fit with the user-space view of signals.
I'd greatly prefer names that really say what these things are. Thus:
SFD_PROCESS_QUEUE + SFD_THREAD_QUEUE or SFD_PROCESS_WIDE_QUEUE + SFD_PER_THREAD_QUEUE or SFD_PROCESS_Q + SFD_THREAD_Q or [some consistent variation of the above]
Thanks,
Michael
-- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Author of "The Linux Programming Interface"; http://man7.org/tlpi/
| |