Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [char-misc-next 01/11] mei: bus: Initial MEI bus type implementation | Date | Thu, 7 Feb 2013 22:41:06 +0000 |
| |
On Thursday 07 February 2013, Tomas Winkler wrote: > +} > +EXPORT_SYMBOL(mei_add_device); > + > +void mei_remove_device(struct mei_bus_client *client) > +{ > + device_unregister(&client->dev); > +} > +EXPORT_SYMBOL(mei_remove_device);
One more point: did you intentionally pick EXPORT_SYMBOL over EXPORT_SYMBOL_GPL here? It is your decision as the copyright holder, but the default is often EXPORT_SYMBOL_GPL these days, to make it clear that you don't expect closed source drivers to plug in there.
Arnd
| |