Messages in this thread | | | Date | Thu, 7 Feb 2013 22:21:53 +0100 | From | Joerg Roedel <> | Subject | Re: [PATCH] intel_iommu: Disable vfio and kvm interrupt assignment when unsafe |
| |
On Thu, Feb 07, 2013 at 09:02:38PM +0000, David Woodhouse wrote: > Backtraces add visibility and have proven to be extremely useful in the > past for getting people to actually *fix* broken BIOSes. > > When kerneloops.org was running, it also gave very good statistics which > helped to apply pressure.
That is true in general, but does not apply to the two warnings in question here. One warning checks for a hypothetical hardware problem and the other warning could happen for several reasons, not only a firmware bug.
It would make sense to put a warning in the respective places where a firmware problem is detected, though. The parse_ioapics_under_ir() function is a candidate where it would make sense, for example. But in the error path of the intel_enable_irq_remapping() function a pr_warn would do the same job.
Joerg
| |