Messages in this thread | | | Date | Thu, 07 Feb 2013 12:13:38 -0700 | From | Stephen Warren <> | Subject | Re: [PATCH] clk: tegra: Implement locking for super clock |
| |
On 02/07/2013 11:57 AM, Mike Turquette wrote: > Quoting Peter De Schrijver (2013-02-07 08:24:14) >> Although tegra_clk_register_super_mux() has a lock parameter, the lock is not >> actually used by the code. Fixed with this patch. >> >> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com> >> --- >> drivers/clk/tegra/clk-super.c | 18 +++++++++++++++--- >> 1 files changed, 15 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/clk/tegra/clk-super.c b/drivers/clk/tegra/clk-super.c >> index 7ad48a8..2fd924d 100644 >> --- a/drivers/clk/tegra/clk-super.c >> +++ b/drivers/clk/tegra/clk-super.c >> @@ -73,7 +73,12 @@ static int clk_super_set_parent(struct clk_hw *hw, u8 index) >> { >> struct tegra_clk_super_mux *mux = to_clk_super_mux(hw); >> u32 val, state; >> + int err = 0; >> u8 parent_index, shift; >> + unsigned long flags = 0; > > I don't think initializing flags to zero is necessary but it is not a > big deal. Is gcc throwing a warning? Otherwise: > > Acked-by: Mike Turquette <mturquette@linaro.org>
I've applied this to Tegra's for-3.9/soc-ccf-fixes branch. If you want to repost given Mike's comments, I can take an updated version.
| |