lkml.org 
[lkml]   [2013]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/3] stop_machine: dequeue work before signal completion
From
On Thu, Feb 7, 2013 at 10:29 AM, Tejun Heo <tj@kernel.org> wrote:
> On Wed, Feb 6, 2013 at 6:21 PM, Namhyung Kim <namhyung@kernel.org> wrote:
>>> Why does this matter? It's inside spinlock. What's being made better
>>> by this change?
>>
>> IIUC the work should be deleted from the list, otherwise it'd trigger
>> BUG_ON when the cpu gets online again.
>
> Ah, okay, the original code was missing list_del_init(), so we end up
> with trashy work list if CPU goes down while there are pending work
> items which will trigger BUG_ON() later when the CPU comes back on.
>
> Hillf, can you please redo the patch description?

Sure, thanks;)
Hillf


\
 
 \ /
  Last update: 2013-02-07 13:41    [W:0.057 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site