Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCH v2] fat: eliminate iterations in fat_search_long and __fat_readdir in case of EOD | Date | Thu, 07 Feb 2013 20:45:14 +0900 |
| |
Namjae Jeon <linkinjeon@gmail.com> writes:
> From: Namjae Jeon <namjae.jeon@samsung.com> > > When doing lookups via fat_search_long(), we can stop checking for > further entries if we detect End of Directory, i.e. if (de->name[0] == > 0x00).The current code traverses the cluster chain of a directory until a hit > is found or till the last cluster for that directory, ignoring the EOD > mark. Fix this. > > Likewise,when readdir(3) is called, we can stop checking for further > entries in __fat_readdir() when we hit EOD.
Don't we need to change fat_get_short_entry()? And did this work correctly about f_pos for readdir?
I'm not thinking about f_pos deeply though, it may have something wrong. Because it stops at middle of cluster.
Thanks. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |