Messages in this thread |  | | Subject | Re: [PATCH 0/2] fix kernel crash with macvtap on top of LRO | From | Ben Hutchings <> | Date | Wed, 6 Feb 2013 23:34:20 +0000 |
| |
On Thu, 2013-02-07 at 01:02 +0200, Michael S. Tsirkin wrote: > At the moment, macvtap crashes are observed if macvtap is attached > to an interface with LRO enabled. > The crash in question is BUG() in macvtap_skb_to_vnet_hdr. > This happens because several drivers set gso_size but not gso_type > in incoming skbs. > The following patches fix this for > Additionally, cbf1de72324a8105ddcc3d9ce9acbc613faea17e is required > to fix this for broadcom - would it make sense to cherry-pick > this patch into 3.8? > > I tested that the patch fixes the crash for ixgbe but > don't have qlogic hardware to fix. I also only tested TCP. > > Feedback wellcome.
If we want to allow forwarding from LRO then net/ipv4/inet_lro.c also needs to set gso_type.
Ben.
-- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.
|  |