Messages in this thread Patch in this message | | | Date | Wed, 6 Feb 2013 14:01:14 -0800 | From | tip-bot for Stephane Eranian <> | Subject | [tip:perf/core] perf evlist: Fix set event list leader |
| |
Commit-ID: 74b2133d19e776924b2773e27dd9d6940f1cc594 Gitweb: http://git.kernel.org/tip/74b2133d19e776924b2773e27dd9d6940f1cc594 Author: Stephane Eranian <eranian@google.com> AuthorDate: Thu, 31 Jan 2013 13:54:37 +0100 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Wed, 6 Feb 2013 18:09:25 -0300
perf evlist: Fix set event list leader
The __perf_evlist__set_leader() was setting the leader for all events in the list except the first. Which means it assumed the first event already had event->leader = event.
Seems like this should be the role of the function to also do this. This is a requirement for an upcoming patch set.
Signed-off-by: Stephane Eranian <eranian@google.com> Acked-by: Jiri Olsa <jolsa@redhat.com> Tested-by: Jiri Olsa <jolsa@redhat.com> Acked-by: Namhyung Kim <namhyung@kernel.org> Cc: Ingo Molnar <mingo@elte.hu> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Namhyung Kim <namhyung.kim@lge.com> Cc: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/20130131125437.GA3656@quad Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/evlist.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index eddd5eb..ecf123e 100644 --- a/tools/perf/util/evlist.c +++ b/tools/perf/util/evlist.c @@ -122,8 +122,7 @@ void __perf_evlist__set_leader(struct list_head *list) leader->nr_members = evsel->idx - leader->idx + 1; list_for_each_entry(evsel, list, node) { - if (evsel != leader) - evsel->leader = leader; + evsel->leader = leader; } }
| |