lkml.org 
[lkml]   [2013]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 26/77] dca: convert to idr_alloc()
    Date
    Convert to the much saner new idr interface.

    Only compile tested.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
    Cc: Maciej Sosnowski <maciej.sosnowski@intel.com>
    Cc: Shannon Nelson <shannon.nelson@intel.com>
    ---
    drivers/dca/dca-sysfs.c | 23 ++++++++++-------------
    1 file changed, 10 insertions(+), 13 deletions(-)

    diff --git a/drivers/dca/dca-sysfs.c b/drivers/dca/dca-sysfs.c
    index 591b659..126cf29 100644
    --- a/drivers/dca/dca-sysfs.c
    +++ b/drivers/dca/dca-sysfs.c
    @@ -53,22 +53,19 @@ void dca_sysfs_remove_req(struct dca_provider *dca, int slot)
    int dca_sysfs_add_provider(struct dca_provider *dca, struct device *dev)
    {
    struct device *cd;
    - int err = 0;
    + int ret;

    -idr_try_again:
    - if (!idr_pre_get(&dca_idr, GFP_KERNEL))
    - return -ENOMEM;
    + idr_preload(GFP_KERNEL);
    spin_lock(&dca_idr_lock);
    - err = idr_get_new(&dca_idr, dca, &dca->id);
    +
    + ret = idr_alloc(&dca_idr, dca, 0, 0, GFP_NOWAIT);
    + if (ret >= 0)
    + dca->id = ret;
    +
    spin_unlock(&dca_idr_lock);
    - switch (err) {
    - case 0:
    - break;
    - case -EAGAIN:
    - goto idr_try_again;
    - default:
    - return err;
    - }
    + idr_preload_end();
    + if (ret < 0)
    + return ret;

    cd = device_create(dca_class, dev, MKDEV(0, 0), NULL, "dca%d", dca->id);
    if (IS_ERR(cd)) {
    --
    1.8.1


    \
     
     \ /
      Last update: 2013-02-06 23:23    [W:4.124 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site