lkml.org 
[lkml]   [2013]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 4/6] kvm tools: powerpc: Fix buglet in xics_init() handling of nrcpus
Date
In xics_init() we set the maximum server to kvm->nrcpus, and then set
the nr_servers using maximum server + 1.

That is off by one, in the harmless direction.

Simplify it to just set nr_servers = kvm->nrcpus.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
tools/kvm/powerpc/xics.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/tools/kvm/powerpc/xics.c b/tools/kvm/powerpc/xics.c
index d4b5caa..cf64a08 100644
--- a/tools/kvm/powerpc/xics.c
+++ b/tools/kvm/powerpc/xics.c
@@ -445,16 +445,13 @@ static void rtas_int_on(struct kvm_cpu *vcpu, uint32_t token,

static int xics_init(struct kvm *kvm)
{
- int max_server_num;
unsigned int i;
struct icp_state *icp;
struct ics_state *ics;
int j;

- max_server_num = kvm->nrcpus;
-
icp = malloc(sizeof(*icp));
- icp->nr_servers = max_server_num + 1;
+ icp->nr_servers = kvm->nrcpus;
icp->ss = malloc(icp->nr_servers * sizeof(struct icp_server_state));

for (i = 0; i < icp->nr_servers; i++) {
--
1.7.10.4


\
 
 \ /
  Last update: 2013-02-06 10:01    [W:0.037 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site