lkml.org 
[lkml]   [2013]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH -v5 6/5] x86,smp: add debugging code to track spinlock delay value
    Subject: x86,smp: add debugging code to track spinlock delay value

    From: Eric Dumazet <eric.dumazet@gmail.com>

    This code prints out the maximum spinlock delay value and the
    backtrace that pushed it that far.

    On systems with serial consoles, the act of printing can cause
    the spinlock delay value to explode. It can still be useful as
    a debugging tool, but is probably too verbose to merge upstream
    in this form.

    Not-signed-off-by: Rik van Riel <riel@redhat.com>
    Not-signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
    ---
    arch/x86/kernel/smp.c | 8 ++++++++
    1 files changed, 8 insertions(+), 0 deletions(-)

    diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c
    index fbc5ff3..660f0ec 100644
    --- a/arch/x86/kernel/smp.c
    +++ b/arch/x86/kernel/smp.c
    @@ -146,6 +146,8 @@ static DEFINE_PER_CPU(struct delay_entry [1 << DELAY_HASH_SHIFT], spinlock_delay
    },
    };

    +static DEFINE_PER_CPU(u32, maxdelay);
    +
    /*
    * Wait on a congested ticket spinlock. Many spinlocks are embedded in
    * data structures; having many CPUs pounce on the cache line with the
    @@ -209,6 +211,12 @@ void ticket_spin_lock_wait(arch_spinlock_t *lock, struct __raw_tickets inc)
    }
    ent->hash = hash;
    ent->delay = delay;
    +
    + if (__this_cpu_read(maxdelay) * 4 < delay * 3) {
    + pr_err("cpu %d lock %p delay %d\n", smp_processor_id(), lock, delay>>DELAY_SHIFT);
    + __this_cpu_write(maxdelay, delay);
    + WARN_ON(1);
    + }
    }

    /*

    \
     
     \ /
      Last update: 2013-02-06 22:42    [W:2.753 / U:0.592 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site