Messages in this thread |  | | From | Arnd Bergmann <> | Subject | Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be) | Date | Wed, 6 Feb 2013 16:27:07 +0000 |
| |
On Wednesday 06 February 2013, Grant Likely wrote: > The only problem that I see is that the ARM and Microblaze > ioread16be/iowrite16be helpers are missing barriers which smells like > a bug and should be fixed.
It looks correct to me on ARM, we use the same barriers in ioread and iowrite that we use in readl/writel.
Microblaze uses no barriers in any of the I/O accessor families (readl, ioread32, in_le32, inl, inl_p), so it presumably doesn't require any because it is fully ordered, at least changing from in_le32 to ioread32 won't make it worse. On a related note, the inb/outb style accessors are bogus on microblaze and should be removed, but that is a different discussion. I should have updated my old patches to introduce a meaningful CONFIG_NO_IOPORT ages ago, and without them it probably breaks.
Arnd
|  |