lkml.org 
[lkml]   [2013]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2] i2c: davinci: update to devm_* API
Hello.

On 06-02-2013 15:22, Vishwanathrao Badarkhe, Manish wrote:

> Update the code to use devm_* API so that driver
> core will manage resources.

> Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@ti.com>
> ---
> Changes since V1:
> - Rebase on top of v3.8-rc6 of linus tree.
> - Apply devm operation on clk_get.

> :100644 100644 6a0a553... da4e218... M drivers/i2c/busses/i2c-davinci.c
> drivers/i2c/busses/i2c-davinci.c | 45 +++++++++++---------------------------
> 1 files changed, 13 insertions(+), 32 deletions(-)

> diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
> index 6a0a553..da4e218 100644
> --- a/drivers/i2c/busses/i2c-davinci.c
> +++ b/drivers/i2c/busses/i2c-davinci.c
[...]
> @@ -699,22 +693,24 @@ static int davinci_i2c_probe(struct platform_device *pdev)
> dev->pdata = &davinci_i2c_platform_data_default;
> }
>
> - dev->clk = clk_get(&pdev->dev, NULL);
> + dev->clk = devm_clk_get(&pdev->dev, NULL);
> if (IS_ERR(dev->clk)) {
> r = -ENODEV;
> goto err_free_mem;
> }
> clk_prepare_enable(dev->clk);
>
> - dev->base = ioremap(mem->start, resource_size(mem));
> + dev->base = devm_request_and_ioremap(&pdev->dev, mem);
> if (!dev->base) {
> r = -EBUSY;

Comment to devm_request_and_ioremap() suggests returning -EADDRNOTAVAIL on
failure. -EBUSY wasn't the right code even before this change, should have
been -ENOMEM.

WBR, Sergei



\
 
 \ /
  Last update: 2013-02-06 13:41    [W:0.040 / U:1.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site