lkml.org 
[lkml]   [2013]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH] rtc: Modify leap year test for more simpler way
By definition, leap year is one, which is a divisible by 4 & 400, excluding multiples of 100s.
Hence I feel this patch is not correct.

Thanks,
Venu


> -----Original Message-----
> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
> owner@vger.kernel.org] On Behalf Of Jonghwa Lee
> Sent: Wednesday, February 06, 2013 4:53 PM
> To: linux-kernel@vger.kernel.org
> Cc: a.zummo@towertech.it; Andrew Morton; rtc-linux@googlegroups.com;
> Jonghwa Lee
> Subject: [PATCH] rtc: Modify leap year test for more simpler way
>
> Leap year which is multiple of 4, just needed 2 LSB for verifying.
> A year with zero for all thease two bits means that it is leap year.
>
> Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
> ---
> include/linux/rtc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/rtc.h b/include/linux/rtc.h
> index 9531845..d662b8d 100644
> --- a/include/linux/rtc.h
> +++ b/include/linux/rtc.h
> @@ -181,7 +181,7 @@ void rtc_timer_do_work(struct work_struct *work);
>
> static inline bool is_leap_year(unsigned int year)
> {
> - return (!(year % 4) && (year % 100)) || !(year % 400);
> + return !(year & 0x3);
> }
>
> #ifdef CONFIG_RTC_HCTOSYS_DEVICE
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/


\
 
 \ /
  Last update: 2013-02-06 13:21    [W:0.062 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site