lkml.org 
[lkml]   [2013]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 26/93] i2c: mxs: Fix type of error code
    Date
    3.5.7.5 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Fabio Estevam <fabio.estevam@freescale.com>

    commit 0f40cbc4f85e13b1a42ae2f41231645a14965872 upstream.

    cmd_err is used to handle error code, so it should not be unsigned.

    This fixes the following warning when building with W=1 option:

    drivers/i2c/busses/i2c-mxs.c: In function 'mxs_i2c_xfer_msg':
    drivers/i2c/busses/i2c-mxs.c:331:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

    Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
    Acked-by: Marek Vasut <marex@denx.de>
    Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
    [ herton: adjust context ]
    Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
    ---
    drivers/i2c/busses/i2c-mxs.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c
    index 04eb441..a505bce 100644
    --- a/drivers/i2c/busses/i2c-mxs.c
    +++ b/drivers/i2c/busses/i2c-mxs.c
    @@ -110,7 +110,7 @@ struct mxs_i2c_dev {
    struct device *dev;
    void __iomem *regs;
    struct completion cmd_complete;
    - u32 cmd_err;
    + int cmd_err;
    struct i2c_adapter adapter;
    };

    --
    1.7.9.5


    \
     
     \ /
      Last update: 2013-02-06 01:41    [W:3.583 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site