Messages in this thread |  | | Date | Tue, 05 Feb 2013 14:23:45 -0800 | From | Cody P Schafer <> | Subject | Re: [PATCH 1/9] mm: add SECTION_IN_PAGE_FLAGS |
| |
On 02/01/2013 04:20 PM, Andrew Morton wrote: > On Thu, 17 Jan 2013 14:52:53 -0800 > Cody P Schafer <cody@linux.vnet.ibm.com> wrote: > >> Instead of directly utilizing a combination of config options to determine this, >> add a macro to specifically address it. >> >> ... >> >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -625,6 +625,10 @@ static inline pte_t maybe_mkwrite(pte_t pte, struct vm_area_struct *vma) >> #define NODE_NOT_IN_PAGE_FLAGS >> #endif >> >> +#if defined(CONFIG_SPARSEMEM) && !defined(CONFIG_SPARSEMEM_VMEMMAP) >> +#define SECTION_IN_PAGE_FLAGS >> +#endif > > We could do this in Kconfig itself, in the definition of a new > CONFIG_SECTION_IN_PAGE_FLAGS.
Yep, I only put it here because it "sounds" the similar to NODE_NOT_IN_PAGE_FLAGS, but (of course) NODE_NOT_IN_PAGE_FLAGS isn't defined based on pure dependencies, while this is.
> I'm not sure that I like that sort of thing a lot though - it's rather a > pain to have to switch from .[ch] over to Kconfig to find the > definitions of things. I should get off my tail and teach my ctags > scripts to handle this.
|  |