Messages in this thread |  | | Date | Tue, 5 Feb 2013 13:18:01 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] mm: break circular include from linux/mmzone.h |
| |
On Tue, 05 Feb 2013 13:56:36 +0800 li guang <lig.fnst@cn.fujitsu.com> wrote:
> ___ 2013-02-04______ 21:20 -0800___David Rientjes_________ > > On Tue, 5 Feb 2013, liguang wrote: > > > > > linux/mmzone.h included linux/memory_hotplug.h, > > > and linux/memory_hotplug.h also included > > > linux/mmzone.h, so there's a bad cirlular. > > > > > > > And both of these are protected by _LINUX_MMZONE_H and > > __LINUX_MEMORY_HOTPLUG_H, respectively, so what's the problem? > > obviously, It's a logical error, > and It has no more effect other than > combination of these 2 header files. > so, why don't we separate them? >
Yup, flattening the hierarchy is nice. And having headers doing mutual inclusion like this is Just Weird.
|  |