Messages in this thread |  | | Date | Tue, 5 Feb 2013 23:06:29 +0800 | Subject | Re: [PATCH 03/13] workqueue: don't set work cwq until we queued it on pool | From | Lai Jiangshan <> |
| |
于 2013/2/5 5:28, Tejun Heo 写道: > Hello, again. > > On Fri, Feb 01, 2013 at 02:41:26AM +0800, Lai Jiangshan wrote: >> @@ -110,6 +110,7 @@ struct delayed_work { >> struct work_struct work; >> struct timer_list timer; >> int cpu; >> + struct workqueue_struct *wq; > > Can't we just replace delayed_work->cpu with delayed_work->cwq? That > way, we don't enlarge delayed_work while encoding both wq and cpu in > delayed_work proper. > > Thanks. >
The @cpu can be WORK_CPU_UNBOUND, and the current code will delay to determine on which cpu should this work be queued until timeout, I didn't want to change this behavior when I.
queue_delayed_work_on(WORK_CPU_UNBOUND, system_wq, dwork, delay);
But there is no "get_cwq(WORK_CPU_UNBOUND, system_wq)". So we have to record the @wq to dwork, Or determine the cpu to queue earlier which changes the current behavior. I'm OK with this change.
Thanks, Lai
PS, again, @cpu and @wq can be saved in dwork.work.entry if needed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |