Messages in this thread | | | Date | Tue, 5 Feb 2013 14:00:48 +0100 | Subject | Re: [PATCH V2 1/6] pinctrl: pinctrl-single: use arch_initcall and module_exit | From | Linus Walleij <> |
| |
On Tue, Feb 5, 2013 at 7:36 AM, Vishwanathrao Badarkhe, Manish <manishv.b@ti.com> wrote:
> I made following changes, in order to update "dip->p" pointer with > correct value: > > - if (!dpi->p) { > + if (IS_ERR_OR_NULL(dpi->p)) { > dpi->p = devm_pinctrl_get(dev); > - if (IS_ERR_OR_NULL(dpi->p)) { > - int ret = PTR_ERR(dpi->p); > - > - dev_dbg(dev, "no pinctrl handle\n"); > - /* Only return deferrals */ > - if (ret == -EPROBE_DEFER) > - return ret; > - return 0; > - } > + ret = PTR_ERR(dpi->p); > + dev_dbg(dev, "no pinctrl handle\n"); > + /* Only return deferrals */ > + if (ret == -EPROBE_DEFER) > + return ret; > + return 0;
This is based on some old code that I wrote ages ago. Check the pinctrl tree or linux-next for the latest core pin grabbing code. Use that instead.
Yours, Linus Walleij
| |