lkml.org 
[lkml]   [2013]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/4] acpi: move x86/mm/srat.c to x86/kernel/acpi/srat.c
From
Date
在 2013-02-04一的 21:35 -0800,David Rientjes写道:
> On Tue, 5 Feb 2013, liguang wrote:
>
> > srat table should present only on acpi domain,
> > seems mm/ is not the right place for it.
> >
> > Reviewed-by: David Rientjes <rientjes@google.com>
>
> I certainly didn't review this, please read
> Documentation/SubmittingPatches.
>
> > Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
>
> Couple of issues with this:
>
> - it doesn't include your followup change "acpi: change Makefile for
> srat.c building" which is required for this to build, please fold it in
> and repost,
>
> - there is whitespace damage, we use tabs for indentation in Makefiles,
>
> - you're basing your patches on Linus' tree when arch/x86/mm/srat has
> changed in linux-next (15 insertions(+), 14 deletions(-)), please
> rebase this on the linux-next tree at git.kernel.org.
>
> Otherwise, looks good.

OK, I'll rebase on linux-next.
Thanks!


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-02-05 07:41    [W:0.066 / U:0.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site