Messages in this thread | | | Date | Mon, 4 Feb 2013 17:36:20 -0600 | From | Scott Wood <> | Subject | Re: [PATCH 4/4] iommu: Add domain window handling functions |
| |
On 02/04/2013 07:02:14 AM, Joerg Roedel wrote: > On Thu, Jan 31, 2013 at 09:32:26AM +0000, Sethi Varun-B16395 wrote: > > We need a mechanism to determine the maximum number of subwindows > supported by PAMU. How about representing it in the iommu_domain > structure: > > struct iommu_domain { > > struct iommu_ops *ops; > > void *priv; > > iommu_fault_handler_t handler; > > void *handler_token; > > struct iommu_domain_geometry geometry; > > u32 max_sub_windows; -----> maximum number of sub windows > supported by the hardware. > > } > > I`ll leave that flag to the private-data of the IOMMU domain. Instead > I > added a DOMAIN_ATTR_WINDOWS attribute to get/set the number of > subwindows. I'll post the updated patch-set soon.
If it's private data, how does the caller know what sort of geometry it can request?
-Scott
| |